Skip to content
This repository was archived by the owner on Feb 27, 2024. It is now read-only.

Update to handle Cabal 3.4 (Dependency 3rd arg is new NonEmptySet). #12

Merged
merged 1 commit into from
May 11, 2021

Conversation

kquick
Copy link

@kquick kquick commented May 10, 2021

Adapts the code to support haskell/cabal#6798 and maintains backward compatibility with previous versions of the Cabal library.

@peti peti merged commit d1a5c7f into NixOS:master May 11, 2021
@peti
Copy link
Member

peti commented May 11, 2021

@kquick kquick deleted the cabal3_4_upd branch May 11, 2021 15:01
sternenseemann added a commit to NixOS/nixpkgs that referenced this pull request Jun 10, 2021
Stackage Nighly recently upgraded their version of hackage-db from 2.1.0
to 2.1.1. 2.1.1 had a compatibility fix for Cabal 3.4 [1]. However it
did not increase the version bound on Cabal nor fails to compile with
Cabal 3.2, so Stackage was able to update it.

Unfortunately hackage-db with Cabal 3.2 causes observable issues [2]
in cabal2nix, so we need to downgrade it for all compilers that still
ship a Cabal version < 3.4.

Also ideally we should update the constraints for hackage-db 2.1.0 and
hackage-db 2.1.1 on hackage. See also [3].

[1]: NixOS/hackage-db#12
[2]: NixOS/cabal2nix#501
[3]: NixOS/hackage-db#14
@sternenseemann
Copy link
Member

This causes NixOS/cabal2nix#501, since the version constraint string needs to be parsed as a Dependency. Likely we can fix this by using PackageVersionConstraint instdead of what formerly used Dependency, gonna try to make a PR later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants